md: fix mddev uaf while iterating all_mddevs list
authorYu Kuai <yukuai3@huawei.com>
Thu, 20 Feb 2025 12:43:48 +0000 (20:43 +0800)
committerSalvatore Bonaccorso <carnil@debian.org>
Thu, 10 Apr 2025 13:32:40 +0000 (15:32 +0200)
commit5b1211ac79f45dcd9dacbf113d6f7887b78aa7c4
treea353ead3fd286fe6cda52eada9ccd9920df0a70f
parent37046cf92520d868e996804e43e168d29427f6a4
md: fix mddev uaf while iterating all_mddevs list

Origin: https://git.kernel.org/linus/8542870237c3a48ff049b6c5df5f50c8728284fa
Bug-Debian: https://bugs.debian.org/1086175

While iterating all_mddevs list from md_notify_reboot() and md_exit(),
list_for_each_entry_safe is used, and this can race with deletint the
next mddev, causing UAF:

t1:
spin_lock
//list_for_each_entry_safe(mddev, n, ...)
 mddev_get(mddev1)
 // assume mddev2 is the next entry
 spin_unlock
            t2:
            //remove mddev2
            ...
            mddev_free
            spin_lock
            list_del
            spin_unlock
            kfree(mddev2)
 mddev_put(mddev1)
 spin_lock
 //continue dereference mddev2->all_mddevs

The old helper for_each_mddev() actually grab the reference of mddev2
while holding the lock, to prevent from being freed. This problem can be
fixed the same way, however, the code will be complex.

Hence switch to use list_for_each_entry, in this case mddev_put() can free
the mddev1 and it's not safe as well. Refer to md_seq_show(), also factor
out a helper mddev_put_locked() to fix this problem.

Cc: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/linux-raid/20250220124348.845222-1-yukuai1@huaweicloud.com
Fixes: f26514342255 ("md: stop using for_each_mddev in md_notify_reboot")
Fixes: 16648bac862f ("md: stop using for_each_mddev in md_exit")
Reported-and-tested-by: Guillaume Morin <guillaume@morinfr.org>
Closes: https://lore.kernel.org/all/Z7Y0SURoA8xwg7vn@bender.morinfr.org/
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name md-fix-mddev-uaf-while-iterating-all_mddevs-list.patch
drivers/md/md.c